Finish speed cap implementation #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
|
Is there any progress on this pull request? |
|
Definitely not from me, and it seems the files in the project haven't had any update in the last 3 years, so I wouldn't count on this happening anytime soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the speed cap max to 2GB. For that I added the uiSyncFixedInt function to utils.c
Fixed the implementation for the buffer so it is maxed at both number of messages and size of the buffer, to avoid bufferbloating. The macro ALLOW_SET_BUFFER_SIZE can be set to allow the user to select the size of the buffer. If left unchecked, a quarter of the speed per second is used (as per common practices).
The buffering/dropping was done for both inbound and outbound packets once it had started. Changed to a packet per packet model to allow for only one direction capping.
Fixed a crash when dropping packets because they weren't popped from the list.